On Sat, 10 Oct 2015, Bob Beck wrote:
> On Sat, Oct 10, 2015 at 04:35:02PM -0700, Philip Guenther wrote:
...
> > @@ -1409,7 +1410,7 @@ recode_credentials(const char *userinfo)
> > char
> > hextochar(const char *str)
> > {
> > - char c, ret;
> > + unsigned char c, ret;
> >
> > c = str[0];
> > ret = c;
> >
>
> Looking at the rest of this and the additions going on, doesn't ret also
> need to be?
You mean the return type of hextochar()? In the end, either here or in
the caller, we need to stuff the resulting character back into a char*
string. Doing the (unsigned char) --> (char) conversion in the
return ret;
statement is the simplest, IMO. Your preference?
Philip Guenther
