> Am 11.10.2015 um 04:38 schrieb Philip Guenther <guent...@gmail.com>:
>
>> --- smtpd/rfc2822.c
>> +++ /tmp/cocci-output-29655-69b554-rfc2822.c
>> @@ -93,13 +93,13 @@ parser_feed_header(struct rfc2822_parser
>> char *pos;
>>
>> /* new header */
>> - if (! isspace(*line) && *line != '\0') {
>> + if (! isspace((unsigned char)*line) && *line != '\0') {
>
> Yep
I would remove the space between '!' and 'isspace()'.
>> - if (isspace(*(pos + 1)))
> > + if (isspace((unsigned char)*(pos + 1)))
>
> Again, array indexing reads better here, IMO:
> if (isspace((unsigned char)pos[1])
Yes.
>> @@ -169,7 +169,7 @@ rfc2822_parser_feed(struct rfc2822_parse
>> char buffer[RFC2822_MAX_LINE_SIZE+1];
>>
>> /* in header and line is not a continuation, execute callback */
>> - if (rp->in_hdr && (*line == '\0' || !isspace(*line)))
>> + if (rp->in_hdr && (*line == '\0' || !isspace((unsigned char)*line)))
>
> Yep.
>
> ok?
ok jung@
