On Wed, Nov 04, 2015 at 07:47:38AM GMT, Jason McIntyre wrote:
> On Wed, Nov 04, 2015 at 03:14:56AM +0000, Raf Czlonka wrote:
> > Hi all,
> > 
> > Some explanation regarding the changes:
> > 
> > - might -> "needs to" - it has to be there, no "might" about it :^)
> > - I've added the additional httpd_flags example back - without it, the
> >   following sentence doesn't make sense. Alternatively the "As can be
> >   seen..." sentence can be removed entirely.
> > - even though "package" hadn't, most likely, been used literally the
> >   words means has a special meaning in OpenBSD, which may lead to some
> >   confusion
> > - since the DNS is being used in brackets, let's expand it properly
> > - named -> nsd has been missed when unbound's been added to the man page
> > - since eigrpd appeared recently, it's a good excuse to add it here
> > - "being running" doesn't sound good
> > 
> > Regards,
> > 
> > Raf
> > 
> > Index: share/man/man8/intro.8
> > ===================================================================
> > RCS file: /cvs/src/share/man/man8/intro.8,v
> > retrieving revision 1.26
> > diff -u -p -r1.26 intro.8
> > --- share/man/man8/intro.8  21 Sep 2015 09:23:35 -0000      1.26
> > +++ share/man/man8/intro.8  4 Nov 2015 02:23:45 -0000
> > @@ -90,11 +90,14 @@ file overrides variable assignments in
> >  .Xr rc.conf 8 .
> >  So to enable
> >  .Xr httpd 8 ,
> > -the following line might be added to
> > +the following line needs to be added to
> 
> this is not really correct. the "might" indicates this is one way to
> enable httpd. as you show yourself immediately below, there are other
> ways.

I specifically meant that the empty 'httpd_flags' enables httpd, and
most other daemons but clearly I don't read "might" in "To enable httpd,
the following line might be added", the same way :^)

> >  .Pa /etc/rc.conf.local :
> >  .Bd -literal -offset indent
> >  httpd_flags=""
> >  .Ed
> > +or
> > +.Bd -literal -offset indent -compact
> > +httpd_flags="-vv"
> 
> without your initial change, this would be unneccessary.

Yep. As I've mentioned earlier, I had only added it back so that the
sentence, which follows it, can be kept intact.

Also, I had missed the end display context there.

> >  .Pp
> >  As can be seen above,
> >  this method is also used to specify additional options.
> > @@ -106,7 +109,7 @@ and the individual pages for the utiliti
> >  .Ss Automounter daemon (amd)
> >  If using the
> >  .Xr amd 8
> > -package,
> > +daemon,
> 
> yes, i agree this is a better choice of words.
> 
> >  go into the
> >  .Pa /etc/amd
> >  directory and set it up by
> > @@ -123,7 +126,7 @@ variables:
> >  .Va amd_flags
> >  and
> >  .Va amd_master .
> > -.Ss Domain Name Server (DNS)
> > +.Ss Domain Name System (DNS)
> 
> that reads better in one way, but worse in another. i honestly think
> it's fine as-is. we could change it to "DNS server" i guess. or servers.

Sure, I only meant the correct expansion of the initialism - especially
since the former is in all caps, and not, i.e. Domain Name server.

However, given that the man page already contains BOOTP/DHCP and NFS
servers in subsection headers, I agree that DNS server simply fits
better.

> >  If you are using a name server, check the
> >  .Pa /etc/resolv.conf
> >  file.
> > @@ -141,7 +144,7 @@ If using a caching name server, add the 
> >  Relevant
> >  .Xr rc.conf 8
> >  variables:
> > -.Va named_flags
> > +.Va nsd_flags
> >  and
> >  .Va unbound_flags .
> >  .Ss Clock synchronisation
> > @@ -224,6 +227,7 @@ variables:
> >  .Ss Routing Daemons
> >  Various daemons for managing routing tables are available:
> >  .Xr bgpd 8 ,
> > +.Xr eigrpd 8 ,
> >  .Xr ospfd 8 ,
> >  and
> >  .Xr ripd 8 .
> > @@ -232,13 +236,14 @@ Relevant
> >  .Xr rc.conf 8
> >  variables:
> >  .Va bgpd_flags ,
> > +.Va eigrpd_flags ,
> >  .Va ospfd_flags ,
> >  and
> >  .Va ripd_flags .
> >  .Ss RPC-based network services
> >  Several services depend on the RPC portmapper,
> >  .Xr portmap 8 ,
> > -being running for proper operation.
> > +running, for proper operation.
> 
> "being running" is correct. i agree it's a difficult concept though. but
> without it, you can read it as several services depend on rpc (running
> for proper operation), where the part i marked in brackets is "one
> thing".

Strange construct indeed - doesn't exactly roll off the tongue, at least
for me :^)

> >  This includes YP and NFS exports, among other services.
> >  .Pp
> >  Relevant
> >
> 
> jmc
> 

I've attached an updated patch, with only the "undisputed" parts :^)

Raf

Index: share/man/man8/intro.8
===================================================================
RCS file: /cvs/src/share/man/man8/intro.8,v
retrieving revision 1.26
diff -u -p -r1.26 intro.8
--- share/man/man8/intro.8      21 Sep 2015 09:23:35 -0000      1.26
+++ share/man/man8/intro.8      4 Nov 2015 10:55:48 -0000
@@ -95,6 +95,10 @@ the following line might be added to
 .Bd -literal -offset indent
 httpd_flags=""
 .Ed
+or
+.Bd -literal -offset indent -compact
+httpd_flags="-vv"
+.Ed
 .Pp
 As can be seen above,
 this method is also used to specify additional options.
@@ -106,7 +110,7 @@ and the individual pages for the utiliti
 .Ss Automounter daemon (amd)
 If using the
 .Xr amd 8
-package,
+daemon,
 go into the
 .Pa /etc/amd
 directory and set it up by
@@ -123,7 +127,7 @@ variables:
 .Va amd_flags
 and
 .Va amd_master .
-.Ss Domain Name Server (DNS)
+.Ss DNS server
 If you are using a name server, check the
 .Pa /etc/resolv.conf
 file.
@@ -141,7 +145,7 @@ If using a caching name server, add the 
 Relevant
 .Xr rc.conf 8
 variables:
-.Va named_flags
+.Va nsd_flags
 and
 .Va unbound_flags .
 .Ss Clock synchronisation
@@ -224,6 +228,7 @@ variables:
 .Ss Routing Daemons
 Various daemons for managing routing tables are available:
 .Xr bgpd 8 ,
+.Xr eigrpd 8 ,
 .Xr ospfd 8 ,
 and
 .Xr ripd 8 .
@@ -232,6 +237,7 @@ Relevant
 .Xr rc.conf 8
 variables:
 .Va bgpd_flags ,
+.Va eigrpd_flags ,
 .Va ospfd_flags ,
 and
 .Va ripd_flags .

Reply via email to