On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default.
I don't have a strong preference. If the team who prefer to get rid
of the stipple (and seem to be the majority of expressed opinons)
agree to take the extra step to try with -retro and/or check
Xorg.0.log carefully before reporting problems to bugs@, I'm ok with
dumping this extra local change.
And eventually the -retro option will be removed upstreams...
>
>
> Index: dix/globals.c
> ===================================================================
> RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v
> retrieving revision 1.11
> diff -u -p -u -p -r1.11 globals.c
> --- dix/globals.c 16 Sep 2015 19:10:20 -0000 1.11
> +++ dix/globals.c 9 Mar 2016 22:57:54 -0000
> @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED
> FontPtr defaultFont; /* not declared in dix.h to avoid including
> font.h in
> every compilation of dix code */
> CursorPtr rootCursor;
> -#ifndef __OpenBSD__
> Bool party_like_its_1989 = FALSE;
> -#else
> -Bool party_like_its_1989 = TRUE;
> -#endif
> Bool whiteRoot = FALSE;
>
> TimeStamp currentTime;
> Index: os/utils.c
> ===================================================================
> RCS file: /var/cvs/xenocara/xserver/os/utils.c,v
> retrieving revision 1.21
> diff -u -p -u -p -r1.21 utils.c
> --- os/utils.c 7 Nov 2015 16:48:53 -0000 1.21
> +++ os/utils.c 9 Mar 2016 22:57:37 -0000
> @@ -579,11 +579,7 @@ UseMsg(void)
> ErrorF("-r turns off auto-repeat\n");
> ErrorF("r turns on auto-repeat \n");
> ErrorF("-render [default|mono|gray|color] set render color alloc
> policy\n");
> -#ifndef __OpenBSD__
> ErrorF("-retro start with classic stipple and cursor\n");
> -#else
> - ErrorF("-retard start with black background and no
> cursor\n");
> -#endif
> ErrorF("-s # screen-saver timeout (minutes)\n");
> ErrorF("-seat string seat to run on\n");
> ErrorF("-t # default pointer threshold (pixels/t)\n");
> @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[
> defaultKeyboardControl.autoRepeat = TRUE;
> else if (strcmp(argv[i], "-r") == 0)
> defaultKeyboardControl.autoRepeat = FALSE;
> -#ifndef __OpenBSD__
> else if ( strcmp( argv[i], "-retro") == 0)
> party_like_its_1989 = TRUE;
> -#else
> - else if ( strcmp( argv[i], "-retard") == 0)
> - party_like_its_1989 = FALSE;
> -#endif
> else if (strcmp(argv[i], "-s") == 0) {
> if (++i < argc)
> defaultScreenSaverTime = ((CARD32) atoi(argv[i])) *
--
Matthieu Herrb
pgpvMXM2ziNi2.pgp
Description: PGP signature
