On 12/04/16(Tue) 15:31, Mike Belopuhov wrote:
> On 12 April 2016 at 15:12, Visa Hankala <[email protected]> wrote:
> > On Fri, Apr 08, 2016 at 12:16:03PM +0000, Visa Hankala wrote:
> >> Every now and then I see "spurious interrupt 34" messages on octeon
> >> serial console. The root cause seems to be in comstart() which enables
> >> the TX holding register empty interrupt before writing data to the TX
> >> register. If the register is empty initially, the early enabling can
> >> trigger a premature interrupt.
> >>
> >> The message does not appear when the enabling is done after the data
> >> writing. The change has not caused ill effects on amd64, i386 and sgi
> >> machines that I used for testing. OK?
> >
> > Any objections to this patch? The timing issue is generic, not specific
> > to octeon.
> >
> 
> Makes sense to me.  Unless there are objections, I think you should put
> this in and watch out for regressions.  OK mikeb otherwise.

I agree, watch for possible regressions ;)

ok mpi@

Reply via email to