On Wed, May 25, 2016 at 08:45:29AM -0400, Ian Darwin wrote: > On 2016-05-25 7:57 AM, Marcus Glocker wrote: > > On Tue, May 24, 2016 at 04:46:57PM -0700, patrick keshishian wrote: > > > > > Hi, > > > > > > I have a "mostly working" driver port for Fushicai Audio-Video > > > Grabber (vendor 0x1b71 product 0x3002). > > > > > > I've had the video bit working for a few days on amd64 and macppc. > > > I finally managed to get the audio bit working this morning on > > > amd64, but still an encoding issue (LE vs BE) on macppc. > > > > > > ... > > > 2. Return values inside parenthesis or not? > > The ongoing religious question :-) Some people say return and sizeof > > shouldn't be used with parenthesis because they are not functions. I > > still find it more readable with parenthesis. We have both variations > > in the tree. Your choice. > "Obviously without" :-) > > > > > 3. Original source filenames were hyphenated (e.g., usbtv-video.c). > > > OK to use underscore instead? I think it is preferred. > > > (Next question may trump this one) > > How's about something a bit shorter, like uvcap.c (USB Video Capture) > > and then also call the driver uvcap? Anyway just a proposal. Otherwise > > yes, replace the '-' by '_' in the filename. > > > > > There are (at least) three other popular usb video capture devices with > totally different chipsets (Syntek, Empia, Somagic, besides this Fushicai > one, "usbtv007"), so calling one of them uvcap might be annoying, like if > one of our many network drivers were called "network". See > https://linuxtv.org/wiki/index.php/Easycap. > Does it make sense to start a naming convention like: utvsyn, utvemp, > utvsom, utvfu, ...? > > Myself I own a Syntek one, which is why I'm aware of this issue: > port 4 addr 3: high speed, power 500 mA, config 1, USB 2.0 Video Capture > Controller(0x0408), Syntek Semiconductor(0x05e1), rev 0.05 >
fwiw. i still have a few "Somagic, Inc. SM-USB 007", for which i have planned to revive a driver i came up with years ago, when iirc. usb stack was still missing something needed to support it completely. would vote for utvsom,.. -Artturi
