On Thu, May 26, 2016 at 16:09 -0700, patrick keshishian wrote: > Hi, > > Included is my initial effort to port the dual-licensed driver > for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). > > As I mentioned in previous email it is "mostly working". I have > tested it on amd64 and macppc. The macppc audio issue mentioned > got resolved thanks to a hint from Alexandre Ratchov; I needed > some education on how to use sndiod :-) Thanks Alex. > > I realize not many of these devices are out in the hands of > people who could test this code, but there are some obvious > bits (especially in the audio ops) that I am "winging", partly > because, the audio interface required them. > > There is .h and two .c files; as mentioned, I kept the original > driver source bits and what I borrowed from uvideo.c separate. > If they must be combine into one .c file, I leave that part to > Marcus Glocker and company. > > My main testing tool has been video(1). I had to modify it for > two reasons: 1. To test the mmap() interface and 2. because > to determine format description video(1) does a strcmp() rather > than use the pixelformat member of the v4l2_fmtdesc struct. > Patch at the very end. Maybe upstream might be interested in > the mmap change? > > Cheers, > --patrick > >
Nice, but the license on these files doesn't include a disclaimer that it itself references. The 2-clause BSD license must include one AFAIK: https://opensource.org/licenses/BSD-2-Clause Additionally stuff like "No physical hardware was harmed running Windows during the reverse-engineering activity" has no place inside the license since it doesn't describe any licensing terms whatsoever. I might be picky, but the flavor text in these licenses is a bit over the top IMO. > Index: dev/usb/utvfu.h > =================================================================== > RCS file: dev/usb/utvfu.h > diff -N dev/usb/utvfu.h > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ dev/usb/utvfu.h 26 May 2016 22:34:38 -0000 > @@ -0,0 +1,172 @@ > +/* $OpenBSD$ */ > +/* > + * Fushicai USBTV007 Audio-Video Grabber Driver > + * > + * Copyright (c) 2013 Lubomir Rintel > + * All rights reserved. > + * No physical hardware was harmed running Windows during the > + * reverse-engineering activity > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions, and the following disclaimer, > + * without modification. > + * 2. The name of the author may not be used to endorse or promote products > + * derived from this software without specific prior written permission. > + * > + * Alternatively, this software may be distributed under the terms of the > + * GNU General Public License ("GPL"). > + */ > + > Index: dev/usb/utvfu.c > =================================================================== > RCS file: dev/usb/utvfu.c > diff -N dev/usb/utvfu.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ dev/usb/utvfu.c 26 May 2016 22:34:38 -0000 > @@ -0,0 +1,691 @@ > +/* $OpenBSD$ */ > +/* > + * Fushicai USBTV007 Audio-Video Grabber Driver > + * > + * Product web site: > + * > http://www.fushicai.com/products_detail/&productId=d05449ee-b690-42f9-a661-aa7353894bed.html > + * > + * Following LWN articles were very useful in construction of this driver: > + * Video4Linux2 API series: http://lwn.net/Articles/203924/ > + * videobuf2 API explanation: http://lwn.net/Articles/447435/ > + * Thanks go to Jonathan Corbet for providing this quality documentation. > + * He is awesome. > + * > + * Copyright (c) 2013 Lubomir Rintel > + * Copyright (c) 2013 Federico Simoncelli > + * All rights reserved. > + * No physical hardware was harmed running Windows during the > + * reverse-engineering activity > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions, and the following disclaimer, > + * without modification. > + * 2. The name of the author may not be used to endorse or promote products > + * derived from this software without specific prior written permission. > + * > + * Alternatively, this software may be distributed under the terms of the > + * GNU General Public License ("GPL"). > + */
