Philip Guenther <[email protected]> writes:

> pax, tar, and cpio are one binary that changes behavior based on the last 
> component of argv[0].  Lots of shared code, so sure, but I find the 
> strcmp() tests in the main code overly complex and perhaps an affront to 
> clear style.  (It's _not_ really a perf issue, as in per-file processing 
> it only checks this for directories and not each file or block.)
>
> So how about we have a enum for the mode that gets set when it decides how 
> to parse the options and is then checked directly after that?  Is this 
> clearer?

I think so, ok jca@

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to