On Mon, 22 Aug 2016 21:05:11 -0700, Philip Guenther wrote:

> pax, tar, and cpio are one binary that changes behavior based on the last 
> component of argv[0].  Lots of shared code, so sure, but I find the 
> strcmp() tests in the main code overly complex and perhaps an affront to 
> clear style.  (It's _not_ really a perf issue, as in per-file processing 
> it only checks this for directories and not each file or block.)
> 
> So how about we have a enum for the mode that gets set when it decides how 
> to parse the options and is then checked directly after that?  Is this 
> clearer?

That seems better to me.  OK millert@

 - todd

Reply via email to