Hi Jeremie,

Jeremie Courreges-Anglas wrote on Wed, Oct 12, 2016 at 03:19:13PM +0200:
> Wouter Clarie <wcla...@gmail.com> writes:

>> The -q flag for the command in a crontab(5) entry was introduced
>> in revision 1.8 of src/usr.sbin/cron/entry.c back in 2001,
>> but never documented.

> Good catch.

>> (Sorry, I'm no hero with mdoc, so not sure if the markup is correct.)

> I'm no mdoc here either, but:
> - I'd drop the first Pp, IMO -q should be described in the same
>   paragraph as other special characters.

That sounds reasonable.

> - I find it weird to use Fl to describe what is technically not
>   a command-line option.  I went with Ql, just like for % and \.

I agree, .Ql is good here.

> Updated diff, assuming the point above are valid; input welcome.

That's already an improvement, so OK schwarze@ if you want to commit.

However, more is missing.

 - It is non-obvious how to delimit "-q".
   If i read the code correctly, it first discards any non-blank
   characters that follow "-q" up to the first blank, and then it
   discards all blank characters up to the next non-blank,
   assuming that non-blank starts the command.
   That logic is too complicated for the manual to explain,
   so i think the manual ought to require a stricter syntax
   and leave behaviour unspecified if people don't stick to that.

   I think i would say something like:

   +If the
   +.Ar command
   +field starts with
   +.Ql -q ,
   +execution will not be logged.
   +Use whitespace to separate
   +.Ql -q
   +from the command.

 - STANDARDS should mention that -q is an extension.


> Index: crontab.5
> ===================================================================
> RCS file: /d/cvs/src/usr.sbin/cron/crontab.5,v
> retrieving revision 1.33
> diff -u -p -p -u -r1.33 crontab.5
> --- crontab.5 30 Jan 2014 20:02:42 -0000      1.33
> +++ crontab.5 12 Oct 2016 13:13:56 -0000
> @@ -193,6 +193,11 @@ will be changed into newline characters,
>  after the first
>  .Ql %
>  will be sent to the command as standard input.
> +If the
> +.Ar command
> +field starts with
> +.Ql -q ,
> +execution will not be logged.
>  .Pp
>  Commands are executed by
>  .Xr cron 8

Reply via email to