On Sun, Jan 22, 2017 at 11:07:00PM +0100, Jeremie Courreges-Anglas wrote: > Stefan Sperling <s...@stsp.name> writes: > > > FreeBSD committed a couple of interesting things in r307529 > > https://svnweb.freebsd.org/base?view=revision&revision=r307529 > > Unfortunately the commit is a giant patch bomb which makes > > it hard to pick out individual fixes :-( > > > > This patch extracts what I believe "fix IQ calibration bug" refers to. > > The current code is only ever setting bits but not clearing bits which > > should be cleared. > > > > My diff looks very different because FreeBSD made a lot of style > > changes in their driver (e.g. they have an rtwn_bb_setbits() function > > which we don't have). We could think about porting these over but > > for now I'd like to focus on fixing bugs instead of style. > > Appears to work fine with > > urtwn0 at uhub0 port 1 configuration 1 interface 0 "vendor 0x0bda ALFA > AWUS036NHR" rev 2.00/2.00 addr 2 > urtwn0: MAC/BB RTL8188RU, RF 6052 1T1R, address 00:c0:ca:xx:xx:xx
Thanks for testing. I should have mentioned that this diff only affects PCI devices since IQ calibration is disabled for USB devices. Running IQ calib has always been causing USB devices to stop receiving packets for some reason.
