Re: ld.so: don't use _dl_exit() for fatal errors

[Todd C. Miller]

On Tue, 24 Jan 2017 15:39:49 +1000, Philip Guenther wrote:

I see this is already in but one minor nit below.

> Index: dl_printf.c
> ===================================================================
> RCS file: /cvs/src/libexec/ld.so/dl_printf.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 dl_printf.c
> --- dl_printf.c       23 Jan 2017 13:00:09 -0000      1.18
> +++ dl_printf.c       24 Jan 2017 05:16:04 -0000
> @@ -237,4 +239,31 @@ kprintn(int fd, unsigned long ul, int ba
>       do {
>               putcharfd(*--p, fd);
>       } while (p > buf);
> +}
> +
> +static char ldso[] = "ld.so: ";

Any reason this can't be const?

 - todd

Index: libexec/ld.so/dl_printf.c
===================================================================
RCS file: /cvs/src/libexec/ld.so/dl_printf.c,v
retrieving revision 1.19
diff -u -p -u -r1.19 dl_printf.c
--- libexec/ld.so/dl_printf.c   24 Jan 2017 07:48:36 -0000      1.19
+++ libexec/ld.so/dl_printf.c   24 Jan 2017 23:20:59 -0000
@@ -241,7 +241,7 @@ kprintn(int fd, unsigned long ul, int ba
        } while (p > buf);
 }
 
-static char ldso[] = "ld.so: ";
+static const char ldso[] = "ld.so: ";
 
 __dead void
 _dl_die(const char *fmt, ...)