Jesper Wallin wrote: > On Mon, Aug 14, 2017 at 05:12:05PM +0200, Klemens Nanni wrote: > > Personally I'd also prefer having this in apmd(8) rather than some other > > daemon or script. Some comments: > > > > You should pass optarg instead of errstr to error(). Either ways error() > > will still append since it uses err(3). This leads to > > > > $ obj/apmd -dz0 > > apmd: invalid percent: too small: Result too large > > > > apmd.8's SYNOPSIS does not reflect your changes. > > Oh, I completely forgot about the SYNOPSIS, my apologies. > > I also went with tedu@'s suggestion for errc(3), but only in the > getopt-loop, as I would most likely do more harm than good trying to > rewrite error(). > > The syslog(3) line, when suspending, was too long and corrected now.
this looks good. will commit soon. (one nit, i'll correct, is man page options are upper case first.)
