Hi,

On Wed, Jan 10 2018, Daniel Loebenberger <daniel_loebenber...@genua.de> wrote:
> Hi Todd,
>
> thank you for your comments!
>
> We have included all the necessary changes in the patch attached.

One thing caught my eye:

> Best regards,
> Daniel, Stefan and Alexander
>
> Index: bin/md5/Makefile
> ===================================================================
> RCS file: /cvs/src/bin/md5/Makefile,v
> retrieving revision 1.15
> diff -u -p -u -p -r1.15 Makefile
> --- bin/md5/Makefile  30 Mar 2016 06:38:40 -0000      1.15
> +++ bin/md5/Makefile  10 Jan 2018 13:43:55 -0000
> @@ -3,9 +3,16 @@
>  PROG=        md5
>  SRCS=        crc.c md5.c
>  MAN= cksum.1 md5.1
> +
>  LINKS=       ${BINDIR}/md5 ${BINDIR}/sha1 \
> +     ${BINDIR}/md5 ${BINDIR}/sha224 \
>       ${BINDIR}/md5 ${BINDIR}/sha256 \
> +     ${BINDIR}/md5 ${BINDIR}/sha384 \

Do we really want these?  For SHA-2, sha256 and sha512 are enough IMHO.

>       ${BINDIR}/md5 ${BINDIR}/sha512 \
> +     ${BINDIR}/md5 ${BINDIR}/sha3-224 \
> +     ${BINDIR}/md5 ${BINDIR}/sha3-256 \
> +     ${BINDIR}/md5 ${BINDIR}/sha3-384 \
> +     ${BINDIR}/md5 ${BINDIR}/sha3-512 \

Same question but for the SHA-3 version.

[...]

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to