On Wed, Oct 03, 2018 at 08:19:26AM +0200, Denis Fondras wrote:
> On Tue, Oct 02, 2018 at 09:13:47PM +0100, Jason McIntyre wrote:
> > On Tue, Oct 02, 2018 at 08:26:02PM +0200, Denis Fondras wrote:
> > > Reorder text and be more precise.
> > >
> > > Index: bgpd.conf.5
> > > ===================================================================
> > > RCS file: /cvs/src/usr.sbin/bgpd/bgpd.conf.5,v
> > > retrieving revision 1.178
> > > diff -u -p -r1.178 bgpd.conf.5
> > > --- bgpd.conf.5 9 Sep 2018 17:11:26 -0000 1.178
> > > +++ bgpd.conf.5 2 Oct 2018 18:25:17 -0000
> > > @@ -445,6 +445,21 @@ The default is
> > > .Ic ignore .
> > > .Pp
> > > .It Xo
> > > +.Ic roa-set
> > > +.Ic { Ar address Ns Li / Ns Ar len Ic maxlen Ar len Ic source-as Ar asn
> > > ... Ic }
> > > +.Xc
> > > +A
> > > +.Ic roa-set
> > > +holds a collection of Validated ROA Payload (VRP).
> >
> > hi.
> >
> > i'm unsure about the terminology exactly. but can you have a "collection
> > of <type> payload"? doesn;t it have to be "payload data" or something?
> >
> > i think at least it needs to be plural (payloads). like, you wouldn;t
> > have a collection of bent umbrella. er, that's as an example..
> >
> > or you could remove "collection of".
> >
>
> Reading RFC6811 (page 4&5), I understand that Validated ROA Payload is one
> prefix in the list. Am I wrong ?
> Ok to make it plural though.
>
it reads fine as plural.
jmc
> > jmc
> >
> > > +Each received prefix is checked against the
> > > +.Ic roa-set
> > > +and the Origin Validation Status (OVS) is set.
> > > +.Bd -literal -offset indent
> > > +roa-set { 192.0.2.0/24 maxlen 24 source-as 64511
> > > + 203.0.113.0/24 source-as 64496 }
> > > +.Ed
> > > +.Pp
> > > +.It Xo
> > > .Ic route-collector
> > > .Pq Ic yes Ns | Ns Ic no
> > > .Xc
> > > @@ -1386,6 +1401,14 @@ can be set to
> > > in which case the nexthop is compared against the address of the
> > > neighbor.
> > > Nexthop filtering is not supported on locally announced networks and one
> > > must
> > > take into consideration previous rules overwriting nexthops.
> > > +.Pp
> > > +.It Xo
> > > +.Ic ovs
> > > +.Pq Ic valid | not-found | invalid
> > > +.Xc
> > > +This rule applies only to
> > > +.Em UPDATES
> > > +where the Origin Validation Status (OVS) matches.
> > > .Pp
> > > .It Ic prefix Ar address Ns Li / Ns Ar len
> > > .It Ic prefix Ar address Ns Li / Ns Ar len Ic prefixlen Ar range
> > >
> >
>
