On Thu, Jan 03, 2019 at 04:06:25PM +0100, Janne Johansson wrote: > Den tors 3 jan. 2019 kl 15:25 skrev Visa Hankala <[email protected]>: > > > > On Thu, Jan 03, 2019 at 01:16:05PM +0300, Mikhael Skvortsov wrote: > > > Tested by running GENERIC.MP built by > > > make CC=clang COMPILER_VERSION=clang > > > on a CN6120 device. > [...] > > > Index: sys/arch/octeon/dev/octcrypto_asm.S > > > =================================================================== > > > RCS file: /cvs/src/sys/arch/octeon/dev/octcrypto_asm.S,v > > > retrieving revision 1.1 > > > diff -u -p -u -r1.1 octcrypto_asm.S > > > --- sys/arch/octeon/dev/octcrypto_asm.S 9 Apr 2018 13:46:15 -0000 > > > 1.1 > > > +++ sys/arch/octeon/dev/octcrypto_asm.S 3 Jan 2019 09:34:57 -0000 > > > @@ -648,7 +648,7 @@ LEAF(octcrypto_ghash_init, 0) > > > dmtc2 t0, MT_GFM_RESINP > > > jr ra > > > dmtc2 t1, MT_GFM_RESINP+1 > > > -END(octcrypto_ghash_set_state) > > > +END(octcrypto_ghash_init) > > This at least seem like a regular mistake in the existing code, > regardless of the rest of the changes/fixups for clang.
You are right. I have committed that part.
