On Fri, Mar 15, 2019 at 09:43:56AM -0600, Todd C. Miller wrote: > Wouldn't it be less error-prone to make escape_char u_char instead > of int?
Maybe, I don't mind either way.
However this in stream_read would still need a cast as ptr is signed:
if (state_change && (u_char)*ptr == escape_char) {
Although there is no reason ptr couldn't be u_char * too (in that case
it would be nice to change line_read as well).
