On Fri, Mar 15, 2019 at 09:51:12PM +0000, Nicholas Marriott wrote:
> On Fri, Mar 15, 2019 at 09:43:56AM -0600, Todd C. Miller wrote:
> > Wouldn't it be less error-prone to make escape_char u_char instead
> > of int?
>
> Maybe, I don't mind either way.
>
> However this in stream_read would still need a cast as ptr is signed:
>
> if (state_change && (u_char)*ptr == escape_char) {
>
> Although there is no reason ptr couldn't be u_char * too (in that case
> it would be nice to change line_read as well).
do_command(char c) was why I didn't go for u_char, and kept it int as
it was in ssh.
I've done some builds of cu with -Wpointer-sign etc., but the output
didn't seem anything like i would like to minimally solve, or cause to
anyone else. :]
-Artturi
