Dear Ingo,

On 4/23/19 9:30 PM, Ingo Schwarze wrote:
>>> Index: rcsfile.5
> [...]
>>> +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>>> +.\"
> 
>> Nitpick: The other man pages in the usr.bin/rcs/ tree do not have a
>> trailing .\" -- except for rcs(1).
>> You may wish to make this consistent this one way or another,
>> likely in a separate commit.
> 
> I put the .\" here because i guess that's the more usual way in
> OpenBSD, but it's not important enough for changing it in existing
> pages.
> 
> [...]

Duly noted.
I wonder if it might be worth noting that somewhere, though I'm not sure
where.

>>> +.Bl -tag -width Ds
>>> +.It Ic date Ar YYYY . Ar mm . Ar dd . Ar HH . Ar MM . Ar SS
>  
>> Are you sure you want to do this without Pf/Ns?
>> You may have inadvertently introduced spaces here and
> 
> Oops, indeed, thanks for catching that.
> Fixed in my tree:
> 
> .It Ic date Ar YYYY . Ns Ar mm . Ns Ar dd . Ns Ar HH . Ns Ar MM . Ns Ar SS
> 
>> Maybe this should be [YY]YY because two-digit years do exist.
> 
> I think the
> 
>   Oo Ar YY Oc Ns Ar YY .
> 
> which that would require would be even more complicated than what
> is there now.  The YYYY can be considered a placeholder, and the
> text already makes it clear that the actual value can be shorter.

Works for me.
With these changes, rcsfile.5 looks okay to me now.

Thank you for your patience.

Fabio

Reply via email to