On Sun, Jun 02, 2019 at 03:21:34PM +0200, Jasper Lievisse Adriaanse wrote: > On Sat, Jun 01, 2019 at 06:12:16PM -0500, Katherine Rohl wrote: > > Couple questions: > > > > > This means no interrupt will be injected. I'm not sure if that's what you > > > want. > > > See vm.c: vcpu_exit_inout(..). It looks like you may have manually > > > asserted the > > > IRQ in this file, which is a bit different than what we do in other > > > devices. That > > > may be okay, though. > > > > The device can assert zero, one, or two IRQs depending on the state of the > > input ports. Are we capable of asserting two IRQs at once through > > vcpu_exit_i8042? > > > > > For this IRQ, if it's edge triggered, please assert then deassert the > > > line. > > > The i8259 code should handle that properly. What you have here is a level > > > triggered interrupt (eg, the line will stay asserted until someone > > > does a 1 -> 0 transition below). Same goes for the next few cases. > > > > Would asserting the IRQs through the exit function handle this for me if > > that???s possible? > > > > > Also, please bump the revision in the vcpu struct for send/receive > > > as we will be sending a new struct layout now. > > > > Where exactly? The file revision? > That would be VM_DUMP_VERSION in vmd.h I reckon. >
Yes, that's what I meant. > -- > jasper >
