On 2019/12/06 15:14, David Gwynne wrote: > > > > On 5 Dec 2019, at 21:14, Sebastian Benoit <[email protected]> wrote: > > > > Claudio Jeker([email protected]) on 2019.12.05 09:53:49 +0100: > >> I would suggest to just pack most of the headers into one group of (). > >> > >> IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1 > >> would become > >> IPv4 (ttl 1 tos 0x20) 10.0.127.15 > 10.0.127.1 > >> and > >> IPv4 ttl 1 [tos 0x20] (id 39958, len 84) 10.0.127.15 > 10.0.127.1 > >> would become > >> IPv4 (ttl 1 tos 0x20 id 39958 len 84) 10.0.127.15 > 10.0.127.1 > >> > >> Maybe add the commas if that is easy to do. > > > > its more readable with commas, i think > > do you want me to come up with something in this space as part of the large > diff, or is the large change generally ok and we can tinker with this stuff > afterward? > > there's some concern that what i'm proposing is too radical and will break > peoples muscle memory.
Personally I'm OK with the general direction and think overall it's quite an improvement. It seems to me that it would make more sense to commit the large change and iterate on top. (for example one tiny obvious difference in the Apple one you showed - it prints IP/IP6 instead of IPv4/IPv6, it's only 1/2 chars but this makes it feel quite a lot more compact - but obviously it would be stupid to re-send a modified version of the big diff with just that changed).
