David Gwynne(da...@gwynne.id.au) on 2019.12.06 15:14:42 +1000: > > > > On 5 Dec 2019, at 21:14, Sebastian Benoit <be...@openbsd.org> wrote: > > > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: > >> I would suggest to just pack most of the headers into one group of (). > >> > >> IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1 > >> would become > >> IPv4 (ttl 1 tos 0x20) 10.0.127.15 > 10.0.127.1 > >> and > >> IPv4 ttl 1 [tos 0x20] (id 39958, len 84) 10.0.127.15 > 10.0.127.1 > >> would become > >> IPv4 (ttl 1 tos 0x20 id 39958 len 84) 10.0.127.15 > 10.0.127.1 > >> > >> Maybe add the commas if that is easy to do. > > > > its more readable with commas, i think > > do you want me to come up with something in this space as part of the > large diff, or is the large change generally ok and we can tinker with > this stuff afterward?
It was just a comment on the readability of lists like that. I like your idea, please proceed whichever way you like. > > there's some concern that what i'm proposing is too radical and will break > peoples muscle memory.
