On 2020/02/23 05:01, Theo de Raadt wrote: > Stefan Sperling <s...@stsp.name> wrote: > > > I don't understand why the installer would matter. Nothing would actually > > change for the installer. We're sure as hell not going to add UTF-8 there. > > The installer's ifconfig would just deal in hex all the way as it does > > today. > > During install finding the right network could be tricky, but that's not a > > new problem. Upgrades would just work once hostname.if contains the right > > hex. > > In upgrade mode, the installer must be able to do the same work as > /etc/netstart -- the installer has a re-implimentation to parse and act > upon hostname.* files. If that behaves different because ifconfig doesn't > act the same way, upgrade won't work right in some circumstances. There's > a small chance your change in behaviour for ifconfig doesn't matter but > I am quite sceptical. >
There's no problem for the installer, Stefan's diff doesn't change the method to set nwid in any case, that always uses 0xXXX, so there is no change to how hostname.if files are handled. The output format remains unchanged for SMALL too, so no need to touch ieee80211_scan() in install.sub. Some scripts do parse ifconfig output on a normal running system (net/wifind in ports, and some users will have local scripts), these need changing for correctness but will only actually break if users use them to connect to a network with a UTF-8 SSID, otherwise they will work as-is. Or most of these can be replaced with "join" instead. The main question is whether ifconfig should have locale support.
