Hi Kurt,
Kurt Mosiejczuk wrote on Tue, May 19, 2020 at 07:49:56PM -0400:
> On Mon, May 18, 2020 at 08:12:00PM +0200, Klemens Nanni wrote:
>> On Mon, May 18, 2020 at 01:20:07PM -0400, Kurt Mosiejczuk wrote:
>>> Learning how LDOMs work on this T4-1 and we only create 8 devices
>>> (each /dev/ldom* and /dev/ttyV*) by default. The now-commonly-available
>>> T4-1 machines can do far more than that pretty easily, so bump up the
>>> number created by default from 8 to 16.
>> Seems reasonable, what about adopting vmd(8) CAVEATS for ldomd(8)?
>> Running out of devices with more guests can be nasty do debug.
> Here's an attempt at doing that. There isn't a man page for the ldom
> devices nor is there one specifically for the ttyV* devices, so I left
> the ".Xr" off of those.
Fair enough as long as those don't exist; if you want to stress that
those correspond to file names (below /dev/ i guess), you can use
".Pa ldom" and/or ".Pa ttyV"; your call.
I can't comment on the content, but:
$ mandoc -Tlint ldom.conf.5
mandoc: ldom.conf.5:136:10: WARNING: new sentence, new line
mandoc: ldom.conf.5:139:1: WARNING: blank line in fill mode, using .sp
mandoc: ldom.conf.5:140:1: WARNING: blank line in fill mode, using .sp
mandoc: ldom.conf.5:134:2: WARNING:
sections out of conventional order: Sh CAVEATS
So here is a version that
* starts the new sentence on a new input line
* avoids trailing blank lines
* puts CAVEATS before BUGS, which is the conventional ordering
Feel free to use that, or parts of it as desired.
Yours,
Ingo
P.S.
Maybe somebody wants to look at writing an ldom(4) manual page,
too? If i understand correctly, then usually, if there is a device
file, having a manual page explaining its purpose is desirable,
right? Or should ldom(4) maybe be an additional .Nm in vldc(4),
with a brief explanation what the purposes of the various vldc
device nodes are? Maybe a FILES section might help there, too?
A bit like audio(4) has an additional name audioctl(4), even though
"audioctl" does not appear in the kernel config files?
Index: ldom.conf.5
===================================================================
RCS file: /cvs/src/usr.sbin/ldomctl/ldom.conf.5,v
retrieving revision 1.13
diff -u -r1.13 ldom.conf.5
--- ldom.conf.5 21 Feb 2020 19:39:28 -0000 1.13
+++ ldom.conf.5 20 May 2020 00:22:39 -0000
@@ -116,6 +116,12 @@
.Xr eeprom 8 ,
.Xr ldomctl 8 ,
.Xr ldomd 8
+.Sh CAVEATS
+Each guest requires one ldom device and one ttyV device per configured
+logical domain.
+Administrators may need to create additional devices using
+.Xr MAKEDEV 8
+if more than 16 logical domains are configured.
.Sh BUGS
The hypervisor requires a machine dependent amount of physical memory that is
reserved automatically.
