On Wed, May 20, 2020 at 09:24:20AM -0600, Theo de Raadt wrote: > Kurt Mosiejczuk <[email protected]> wrote:
> > > Seems reasonable, what about adopting vmd(8) CAVEATS for ldomd(8)? > > > Running out of devices with more guests can be nasty do debug. > > Here's an attempt at doing that. There isn't a man page for the ldom > > devices nor is there one specifically for the ttyV* devices, so I left > > the ".Xr" off of those. > Let's step back. Why is it nasty to debug? > What errors are shown? What errors are not shown? Is there an error > reporting missing? Should the code *inspect* for that condition, and > report a warning or error, on stderr or via logging? > If it did, would that make the proposed manual page change redundant? Yeah. The code definitely needs improvement on that front. I've seen parts where it isn't checking return codes on operations on the devices. Part of this started because rcctl reports ldomd starting just fine but ldomd dies if it cannot access a device. I suppose we could look at having ldomctl throw a warning if there are not enough ldom and ttyV devices for the configuration file presented. --Kurt
