Klemens Nanni <k...@openbsd.org> wrote: > On Fri, May 22, 2020 at 05:57:37PM -0600, Theo de Raadt wrote: > > There is an internal VCPU #define, but the keyword is vcpu, and there > > appears to be nothing coming from the system which is an uppercase VCPU > > > > We don't have pfctl spitting out messages like: invalid RDOMAIN, because > > rdomain is the keyword, there is no reason to arbitrarily change things > > from LOWERCASE to UPPERCASE or even CamelCase. > Yes, although those error messages read fine to me with uppercase "VCPU" > as well, regardless of whether the keyword is "vcpu" or "cpu", because > they talk about the resources per se that are managed, not a particular > line in the configuration file that is ill written.
I think your argument is completely hopeless. My comment is about UPPERCASE vs lowercase. Not about whether it is cpu or vcpu. But about UPPERCASE. Why not make it VcPu then? You are trying to defend an arbitrary difference.
