Am 15.07.2020 um 23:51 schrieb Sebastian Benoit: >> src/usr.sbin/acme-client/parse.y: >> * The grammar allows the user to omit the newline after the first line >> in a domain or authority block. > > Yes. I'm still pnodering this. What are the chances that someone does that? > > Probably no one does, but it worthwhile to break someones config for such a > change?
I can't imagine that anyone uses this, I only noticed it by reading the grammar. But still not an important fix, I just noticed it and wanted to point it out... >> src/usr.sbin/acme-client/dbg.c doesn't build because in the included >> header file extern.h the type pid_t is missing (unistd.h). > > extern.h should #include <sys/types.h> for that, no? Yes, sys/types.h is better, sorry about that. Also it would be nice to have a feature to update all domains of the config file. I currently do that in a shell script by parsing the output of acme-client -nv with sed and then calling acme-client multiple times. Maybe an easy solution would be an option that prints the list of all domains, so I can avoid the sed parsing, as this is prone to breaking. Another solution is obviously to just add an "update all" command line option (or maybe even in the config?), but that is probably more complicated to implement. What do you think about that?
