Hi, On Wed, 12 Aug 2020 12:38:39 +0300 Vitaliy Makkoveev <m...@openbsd.org> wrote: > We don't need to mark pppx(4) sessions because there is no special cases > for them. We just need to kill pppx(4) related "pr_timeout_sec != 0" > checks and call pipex_get_closed() by pppx_get_closed().
How do you implement that by calling pipex_get_closed() by pppx_get_closed()? PIPEXGCLOSED is to pick up expired sessions which is associated with the character device (/dev/{pppx,pppac}0). In pppac(4) case, the character device is the same object of the interface pppac. But pppx(4) is not the same. pipex_session has no direct referece to the device. This is why my diff was modifying pipex_get_closed().