On Wed, Aug 12, 2020 at 09:07:15PM +0900, YASUOKA Masahiko wrote:
> Hi,
>
> On Wed, 12 Aug 2020 12:38:39 +0300
> Vitaliy Makkoveev <m...@openbsd.org> wrote:
> > We don't need to mark pppx(4) sessions because there is no special cases
> > for them. We just need to kill pppx(4) related "pr_timeout_sec != 0"
> > checks and call pipex_get_closed() by pppx_get_closed().
>
> How do you implement that by calling pipex_get_closed() by
> pppx_get_closed()?
>
>
> PIPEXGCLOSED is to pick up expired sessions which is associated with
> the character device (/dev/{pppx,pppac}0). In pppac(4) case, the
> character device is the same object of the interface pppac. But
> pppx(4) is not the same. pipex_session has no direct referece to the
> device. This is why my diff was modifying pipex_get_closed().
>
You are right. I have my own tree where I divided pppx(4) sessions and
iface_context. So in my tree I have one `pipex_iface_context' in `struct
pppx_dev' and the usage of most pppx(4) is identical to pppac(4). Sorry,
I forgot that it's not shared yet :(
You are right, pppx_get_closed() still needs to do it's own
`pipex_close_wait_list' walkthrough.
