Todd C. Miller <todd.mil...@sudo.ws> wrote: > On Sat, 26 Dec 2020 10:45:21 -0700, "Theo de Raadt" wrote: > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > with FreeBSD and Linux. > > > > More than half the stuff being touched doesn't exist in FreeBSD or Linux. > > > > SIMPLEQ_ goes back to 97. > > STAILQ goes back to 96. NetBSD invented SIMPLEQ after STAILQ already > existed. Personally, I find STAILQ much more natural--the naming > of SIMPLEQ lacks any real meaning to me. > > I'd settle for just including STAILQ in queue.h, but when we discussed > this last time you were not opposed to replacing SIMPLEQ with STAILQ. > Having code in base that uses both types seems like a mistake.
Well in that case this should still be a multistep process. Add STAILQ Convert things, including everything in ports No diff should change a line of code before it's time (and the tabs vs spaces part of the diff makes this incredibly difficult to evaluate)
