On 2021/05/20 08:36, Theo Buehler wrote: > On Thu, May 20, 2021 at 07:05:24AM +0100, Stuart Henderson wrote: > > When I have time (I'm hopeful for next week but not sure yet) I'll > > see how this goes with a ports bulk build. > > This diff changes usr.sbin/tcpdump/nameser.h rather than <arpa/nameser.h> > I don't think this affects any ports.
Oops, sorry Matthew, I read this too quickly and missed that it was for tcpdump. > Surely the T_XXX -> ns_t_xxx change and similar would be needed in > /usr/src/include/arpa/nameser.h? Yes that's what I was thinking this was touching.. > The two headers have diverged a bit and there may be a case for keeping > them in sync (I don't know), but changing only tcpdump's copy doesn't > make sense to me, especially as "upstream" still uses T_XXX. > > I don't know why tcpdump uses both its own copy and <arpa/nameser.h>. >
