Matthew Martin <phy1...@gmail.com> wrote: > On Tue, May 18, 2021 at 10:24:00PM -0500, Matthew Martin wrote: > > Sync the DNS types with IANA[1] and upstream[2]. With this the Type65 > > queries show up as HTTPS. > > > > Removed the UNSPECA type parsing as IANA has that query type number > > assigned to NID now. > > > > Also added a const on ns_class2str. > > > > 1: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml > > 2: https://github.com/the-tcpdump-group/tcpdump/pull/912
I would be happier if /usr/include/arpa/nameser.h was updated properly FIRST. This would involved merging facts from both sides to make it correct, then the tcpdump file can get deleted. There are some almost scary differences: +#define MAXDNAME 256 /* maximum domain name */ This is not used in tcpdump. But it is scary because if someone used it, and attempted to interface to some other library function, they would be operating on definition different from the system. That is a nono. I'll take a shot at the merge.