On Tue, Oct 19, 2021 at 06:08:04PM +1100, Jonathan Gray wrote: > On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > > Hi, > > > > Simple online diff for properly nullify v_data (which is `void *`) > > with NULL instead of 0. > > > > Comments or OK ? > > -- > > Sebastien Marie > > > > There are many others along those lines in the kernel, for example > sparse complains about these in vfs_subr.c > > /sys/kern/vfs_subr.c:274:64: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:275:64: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:430:32: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:467:22: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:533:50: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:1150:77: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:1430:42: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:1483:19: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:1752:25: warning: Using plain integer as NULL pointer > > If this is something worth changing should it be a larger diff?
I am playing^Wworking inside vnode, so my eyes was only hurted by v_data initialisation. But I would be happy to avoid using 0 and use NULL at others places. -- Sebastien Marie
