On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote:

> There are many others along those lines in the kernel, for example
> sparse complains about these in vfs_subr.c
>
> /sys/kern/vfs_subr.c:274:64: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:275:64: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:430:32: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:467:22: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:533:50: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:1150:77: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:1430:42: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:1483:19: warning: Using plain integer as NULL pointer
> /sys/kern/vfs_subr.c:1752:25: warning: Using plain integer as NULL pointer
>
> If this is something worth changing should it be a larger diff?

I think it is worth changing.  Using NULL in place of 0 makes the
code easier to parse for humans too.

 - todd

Reply via email to