Stuart Henderson <[email protected]> wrote:

> > +#ifdef __amd64__
> > +   /* Ignore com(4) at isa(4) */
> > +   if (aaa->aaa_addr[0] == 0x3f8 || aaa->aaa_addr[0] == 0x2f8 ||
> > +       aaa->aaa_addr[0] == 0x3e8 || aaa->aaa_addr[0] == 0x2e8)
> > +           return 0;
> > +#endif
> 
> One of the benefits of using ACPI to pick up UARTs is that it can cope
> with vendors who have screwed up their interrupt assignments (the most
> common mistake I've encountered is to have 0x3f8 irq3 / 0x2f8 irq4),
> I think this part of the diff will prevent that from working.
> 
> Also, it's more than just amd64 ;)

This part of the diff makes the acpi attachment ignore any uart at the 4
major addresses, as such they remain on isa, where the problem will
resurface.

Reply via email to