argv += optind;
        argc -= optind;

+       if (pemmode) {
+               if (pledge("stdio rpath", NULL) == -1)
+                       err(1, "pledge");
+


rpki-client is starting to develop quite a number of run-time "modes".

I think it is time to add some checks (right around argc -=optind) to
identify non-sensical combinations and not proceed.  Also, there should
be no extra arguments.

To give an example, what does this do:

    $ rpki-client -p OOFPkv3HzPv8GCNhUjrifWl-lS8.mft foo foo foo 

It ignores the additional arguments.

I'm just saying this has become a bit sloppy, there are so many
non-sensical combinations now and it isn't clear what they will do.
Time to get strict?



Reply via email to