Re: rpki-client: print info about encapsulated certs & PEM format in filemode

[Theo Buehler]

On Thu, Aug 25, 2022 at 05:06:33PM +0000, Job Snijders wrote:
> On Thu, Aug 25, 2022 at 06:38:36PM +0200, Theo Buehler wrote:
> > On Thu, Aug 25, 2022 at 04:04:27PM +0000, Job Snijders wrote:
> > > On Thu, Aug 25, 2022 at 03:38:45PM +0200, Claudio Jeker wrote:
> > > > I wonder why is PEM printing not part of -f? It seems to be something
> > > > that should be part of filemode.
> > > 
> > > OK, how about this?
> > 
> > That's a lot better. However X509_print() generates much visual noise
> > and hides the things I'm primarily interested in.  I like the current
> > concise output of -f mode.
> > 
> > Can we put the X509_print() behind the -v flag and keep the
> > PEM_write_bio_X509() behind -p?
> 
> Sure.
> 
> > More comments inline.
> 
> Addressed.

Thanks.

> 
> OK?

ok.

If you don't mind one last nit: could you put braces around the inner
ifs, please?

                if (verbose) {
                        if (!X509_print_fp(...)
                                errx(...)
                }

                if (printpem) {
                        if (...)
                        ...
                }