On Fri, Aug 26, 2022 at 05:27:08PM +0200, Claudio Jeker wrote:
> On Fri, Aug 26, 2022 at 04:15:43PM +0100, Stuart Henderson wrote:
> > On 2022/08/26 09:49, Klemens Nanni wrote:
> > > grep and CVS agree that this is a switch(4) left-over.
> > >
> > > OK?
> >
> > This is exported to userland isn't it?
>
> I seariously hope not. All those caddr_t are kernel pointers.
> In general the structs in *var.h are normally only kernel internal.
>
The 'ifnet' structure is not exported to userland. Also it declared
within "#ifdef _KERNEL" block.
This diff is ok by me.
> > If so, I think all ports using it will need a bump.
> >
> >
> > > Index: if_var.h
> > > ===================================================================
> > > RCS file: /cvs/src/sys/net/if_var.h,v
> > > retrieving revision 1.114
> > > diff -u -p -r1.114 if_var.h
> > > --- if_var.h 20 Feb 2021 04:55:52 -0000 1.114
> > > +++ if_var.h 26 Aug 2022 09:47:37 -0000
> > > @@ -133,7 +133,6 @@ struct ifnet { /* and
> > > the entries */
> > > int if_pcount; /* [N] # of promiscuous listeners */
> > > unsigned int if_bridgeidx; /* [K] used by bridge ports */
> > > caddr_t if_bpf; /* packet filter structure */
> > > - caddr_t if_switchport; /* used by switch ports */
> > > caddr_t if_mcast; /* used by multicast code */
> > > caddr_t if_mcast6; /* used by IPv6 multicast code */
> > > caddr_t if_pf_kif; /* pf interface abstraction */
> > >
> >
>
> --
> :wq Claudio
>
