On Tue, Mar 28, 2023 at 03:35:46PM +0200, Claudio Jeker wrote: > This diff moves prefix_write to rde_prefix.c and renames it to pt_write. > The function now takes a struct pt_entry * as argument and with this the > extra indirection via pt_getaddr() falls away.
I'm ok with this, although it's not entirely obvious to me why this is better. I found this diff hard to review. Perhaps you could land it with an intermediate step that only moves the two functions without doing anything else. Once I did this, it was a lot easier to see what happened.
