----- Original Message ----
From: Dave Howorth <[email protected]>
To: [email protected]
Sent: Monday, July 20, 2009 5:29:36 AM
Subject: Re: [Templates] RT Ticket 47850 and attached patch

Slaven Rezic wrote:
> I think that the pod2html renderer used at perldoc.perl.org is broken.
> If you compare both versions on search.cpan.org, then there's no
> difference:
>  
> http://search.cpan.org/~nwclark/perl-5.8.7/pod/perlpod.pod#Formatting_Codes
>  
> http://search.cpan.org/~rgarcia/perl-5.10.0/pod/perlpod.pod#Formatting_Codes____

That's a relief! Thanks for that - My CPAN search didn't show up the
5.10 version, which surprised me; my fu isn't strong on Monday mornings.

So POD allows URLs but not HTML elements, which seems desirable to me
for translation to other output formats. And so I think that means the
patch is broken, as well as the original. I guess it needs something like:

  First of all, make sure that your template files define a Byte Order
  Mark (BOM, see L<http://en.wikipedia.org/wiki/Byte_Order_Mark>).

Cheers, Dave

I'm happy to make this change if it works.  I'll give it a go.  However
I really think this test and the other pod tests should not be run
unless you are in author mode, since they cause pointless breakage.  

At the minimum I would add some sort of "SKIP ALL unless
$ENV{RUN_AUTHOR_TESTS}" for these tests.  There are actually better
ways to fix this problem but they all involve more dependencies and
deeper changes than  may be allowed. 

I would add this flag to the pod and kwalitee tests.  There is really
no reason to run those for end users.  It's started to become the norm
for distros to package those quality type tests separately since they
cause a lot of pointless and meaningless breakage for the end users.

If we agree I can make those changes tonight and submit a new patch.  Let me 
know what you think.  


John



      

_______________________________________________
templates mailing list
[email protected]
http://mail.template-toolkit.org/mailman/listinfo/templates

Reply via email to