Eric Saxe wrote:
> Here is the webrev for the DTrace probes that powertop is consuming:
>
> - cpu_speed_change
> - idle_state_transition (formerly cstate_transition)
> - cyclic_{start | end}
>
> Please take a look, and send out any comments / feedback. I'd like to
> get these integrated into Nevada so that Powertop can be otherwise self
> contained.
>
> I've incorporated Sasha's suggestion to avoid conditionals/dereferencing
> in the probe implementation, have renamed the "cstate_transition" probe
> to something more suitably platform independent, and have #defined the
> idle CPU states.
>
> http://cr.opensolaris.org/~esaxe/probes/
>
I finally got the last bit of code review feedback I had been waiting
for. :)
I've updated the webrev, the only change being that the "type" arguments
in the cpudrv.c DTrace probe were incorrect (they should be
pointers)....with all else being the same.
Thanks,
-Eric
