Bill Holler wrote:
> Hi Eric,
>
> Would it be better to place the SPARC IDLE_STATE_* defines in
> sparc/sys/cpu.h instead of sun4*/os/mach_startup.c?
> This would match the x86 directory tree which places IDLE_STATE_*
> defines in header file intel/sys/cpu.h.
The states are different depending on whether it's sun4v or not, since
with sun4v in that path the CPU doesn't actually halt, it yields to the
hypervisor. That's why I split it out...
Thanks,
-Eric
> Regards,
> Bill
>
> Eric Saxe wrote:
>> Here is the webrev for the DTrace probes that powertop is consuming:
>>
>> - cpu_speed_change
>> - idle_state_transition (formerly cstate_transition)
>> - cyclic_{start | end}
>>
>> Please take a look, and send out any comments / feedback. I'd like to
>> get these integrated into Nevada so that Powertop can be otherwise
>> self contained.
>>
>> I've incorporated Sasha's suggestion to avoid
>> conditionals/dereferencing in the probe implementation, have renamed
>> the "cstate_transition" probe to something more suitably platform
>> independent, and have #defined the idle CPU states.
>>
>> http://cr.opensolaris.org/~esaxe/probes/
>>
>> Thanks,
>> -Eric
>>
>>
>> _______________________________________________
>> tesla-dev mailing list
>> tesla-dev at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/tesla-dev
>>
>
