Rafael.Vanoni wrote: > Li, Aubrey wrote: >> Rafael.Vanoni wrote: >> >>> Li, Aubrey wrote: >>>> [snip] >>>>>> And battery_stat_snapshot() calls battery probe to do the rest >>>>>> job. I can make a patch for it if you like. Here's a patch for >>>>>> it. >>>>> thanks >>>>> Rafael >>>> Wow, you are always so quick, :-) >>>> Thanks for the patch, it looks great, please feel free to commit. >>> Sometimes a little too fast ;) >>> Here's a better patch, the previous one had a small memory leak. >> >> Hmm..., the patch became a bit complicated. >> If so, kstat_battery_mod should be freed every return of ksp == NULL, >> shouldn't it? > > Yes. I was also thinking that this is executed in a loop, and > there's no > need to check the module name every time. Here's a simpler patch. > Good enough, please feel free to commit. Which revision of ON will include acpi_drv instead of battery?
Thanks, -Aubrey
