Li, Aubrey wrote: > Rafael.Vanoni wrote: > >> Li, Aubrey wrote: >>> [snip] >>>>> And battery_stat_snapshot() calls battery probe to do the rest job. >>>>> I can make a patch for it if you like. Here's a patch for it. >>>> thanks >>>> Rafael >>> Wow, you are always so quick, :-) >>> Thanks for the patch, it looks great, please feel free to commit. >> Sometimes a little too fast ;) >> Here's a better patch, the previous one had a small memory leak. > > Hmm..., the patch became a bit complicated. > If so, kstat_battery_mod should be freed every return of ksp == NULL, > shouldn't it?
Yes. I was also thinking that this is executed in a loop, and there's no need to check the module name every time. Here's a simpler patch. >>> How about the OpenSolaris conference? anything about the power? >> David Stewart gave the keynote on Thursday. One of the things >> he talked >> about was PM and PowerTOP. But other than that, nothing power related. >> > > I found this link: > http://www.osdevcon.org/2008/program.html > But somehow your slides is not available, it would be great if you can > send it to me, :-) Cool, I'll send the slides off list. They should appear on the website any time now too. thanks Rafael > Thanks, > -Aubrey > _______________________________________________ > tesla-dev mailing list > tesla-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/tesla-dev -------------- next part -------------- A non-text attachment was scrubbed... Name: kstat.diff Type: text/x-patch Size: 3565 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/tesla-dev/attachments/20080701/275bd759/attachment.bin>
