This is an interesting suggestion, but thrift-dev is definitely not the right forum to discuss it. We should write up a document (wiki?) describing the issues and possible solutions and bring it up on the list Doug suggested ([EMAIL PROTECTED]).
--David Kevin Ballard wrote: > Git has built-in support for adding a > > Signed-off-b-y: Real Name <[EMAIL PROTECTED]> > > line to any commit. The linux and git repos use this to verify that > the contributor either wrote the code, or is personally verifying that > the author of the code is allowing it to be included in the project. > For third-party contributors, this means that any patch that is not > accompanied by that line will be thrown out instantly, and any patch > that is can then be reviewed by a maintainer, and if it's accepted > then the maintainer adds their own Signed-off-by line. > > We could use this functionality as a way of saying the author of this > code understands that his contribution falls under the terms of the ASL. > > -Kevin Ballard > > On Jun 11, 2008, at 1:10 PM, David Reiss wrote: > >> Well, Todd signed an ICLA, but this is definitely an issue for new >> contributors. Git commits have globally-unique unforgable hashes that >> identify not just the patch but the entire repository history >> (including >> file contents and commit messages) leading up to the commit. We could >> make it pretty easy for a contributor to copy and paste the hash >> (along >> with a link to the commit) into a JIRA ticket and check a box for >> that, >> but this is definitely something to discuss with the legal folks. For >> now, I was not planning to accept Git-based patches into trunk from >> anyone without an ICLA. >> >> Doug Cutting wrote: >>> David Reiss wrote: >>>> Actually, Todd is not a committer, so I pull the branch and >>>> dcommit it myself. I have found pulling Git branches to be much >>>> less >>>> error prone than downloading and applying patches. >>> >>> When does Todd click the box stating that he understands his >>> contribution is made under the terms of the Apache Software License? >>> Are you willing to vouch for Todd on this? Probably not. I'm not >>> sure >>> whether this is absolutely required, perhaps a question for >>> [EMAIL PROTECTED] >>> >>> Doug > > -- > Kevin Ballard > [EMAIL PROTECTED] > > >
