Bryan Duxbury wrote:
In Hadoop and HBase, there's a status for issues called "Patch Available", which we use to indicate that the issue has a patch ready to be reviewed and/or applied. I think we should make a Patch Available status as well as an Awaiting Commit status in our Jira.
There are different ways to do this in Jira. One is to use the workflow, as Hadoop does. The disadvantage of this is that workflows are very heavyweight in Jira. You cannot change a workflow that's in use, but rather have to create a new workflow, then assign it to the project, which edits every issue in the project to give it the new workflow. There are a few minor permission bugs in Hadoop's workflow that we'll probably never fix because of this.
Another approach is to add checkbox-based flags to the issue. This is what Lucene does. Each issue has a "Lucene fields:" section that shows the currently set flags. When you edit the issue, or make a workflow transition, you have the opportunity to change the flags. You can also filter searches based on flags. The advantage is that flags and other fields can be added and altered much more easily than the workflow.
So, unless someone objects, I will add a "Patch Available" flag to Thrift's Jira. I could also add a "Reviewed" flag, but I personally find that redundant: a reviewer should either commit and resolve the issue, or unset the patch available flag to reject the patch (with a clear explanation in a comment, of course).
I will also add a "Thrift Review Queue" saved query that folks can bookmark, add to their home page in Jira, etc. This would list all issues whose "Patch Available" flag is set, and is a good thing for committers to monitor and try to keep short.
Doug
