[
https://issues.apache.org/jira/browse/THRIFT-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613133#action_12613133
]
David Reiss commented on THRIFT-77:
-----------------------------------
This is a big improvement in code, quality. Thanks for submitting it. I've
made a few tweaks.
My full diff:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=treediff;h=6373742;hp=fb1007d;hb=6373742;hpb=fb1007d
Diff from original to mine:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=6373742
I fixed a few bugs in TOuput::printf, added a few comments, and restored
errno_copy in a few places where the string constructor could possibly blow
away errno by allocating memory.
Thoughts?
> Remove fprintf from C++ lib
> ---------------------------
>
> Key: THRIFT-77
> URL: https://issues.apache.org/jira/browse/THRIFT-77
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Alexander Shigin
> Priority: Minor
> Attachments: thrift-lib-cpp-remove-printf.patch
>
>
> The patch introduces two new methods for TOutput: perror and printf. These
> two methods are needed because:
> 1. TNonblocking has a couple of "fprintf(stderr, ""...);" clauses.
> 2. There is a lot similar lines in lib/cpp:
> {code}
> string errStr = "TNonblockingServer::Task: close, possible resource leak " +
> TOutput::strerror_s(errno);
> GlobalOutput(errStr.c_str());
> {code}
> The patch also uses the introduced methods to fix all these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
