[
https://issues.apache.org/jira/browse/THRIFT-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613153#action_12613153
]
Alexander Shigin commented on THRIFT-77:
----------------------------------------
I'm agreed with most changes, except one.
You've converted stack_buf to static variable. I can be wrong, but this change
makes TOutput.printf thread unsafe.
> Remove fprintf from C++ lib
> ---------------------------
>
> Key: THRIFT-77
> URL: https://issues.apache.org/jira/browse/THRIFT-77
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Alexander Shigin
> Priority: Minor
> Attachments: thrift-lib-cpp-remove-printf.patch
>
>
> The patch introduces two new methods for TOutput: perror and printf. These
> two methods are needed because:
> 1. TNonblocking has a couple of "fprintf(stderr, ""...);" clauses.
> 2. There is a lot similar lines in lib/cpp:
> {code}
> string errStr = "TNonblockingServer::Task: close, possible resource leak " +
> TOutput::strerror_s(errno);
> GlobalOutput(errStr.c_str());
> {code}
> The patch also uses the introduced methods to fix all these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
