[
https://issues.apache.org/jira/browse/THRIFT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Duxbury updated THRIFT-179:
---------------------------------
Attachment: thrift-179-v3.patch
This version handles all your comments.
As far as whether we should add the docstring to both getter and setter, what
would the alternative be? Choosing one or the other is pretty arbitrary.
There's not really much cost to adding it to both.
> Generated code should incorporate per-field doc strings
> -------------------------------------------------------
>
> Key: THRIFT-179
> URL: https://issues.apache.org/jira/browse/THRIFT-179
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Attachments: thrift-179-v2.patch, thrift-179-v3.patch,
> thrift-179.patch
>
>
> Generated java code for Thrift structs should have doc strings from the
> .thrift file. The information is all there, it's just not made part of the
> generated code.
> In the default java generator, the doc strings would go on the field
> declarations. In the bean style generator, the the doc string would go on
> both the generated getters and setters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
