[
https://issues.apache.org/jira/browse/THRIFT-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643377#action_12643377
]
David Reiss commented on THRIFT-179:
------------------------------------
I made this (semi-)independent change:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=2e045a6
I'm planning to commit it on its own.
This allowed me to make this change to v3:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=0350c04
The result is this diff, which I am planning on committing as a separate diff
from the first:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=treediff;h=0350c04;hp=2e045a6
Thoughts?
> Generated code should incorporate per-field doc strings
> -------------------------------------------------------
>
> Key: THRIFT-179
> URL: https://issues.apache.org/jira/browse/THRIFT-179
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Attachments: thrift-179-v2.patch, thrift-179-v3.patch,
> thrift-179.patch
>
>
> Generated java code for Thrift structs should have doc strings from the
> .thrift file. The information is all there, it's just not made part of the
> generated code.
> In the default java generator, the doc strings would go on the field
> declarations. In the bean style generator, the the doc string would go on
> both the generated getters and setters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
